Update Swift example to use SwiftUI #2416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
approved these changes
Feb 28, 2024
mattrobmattrob
pushed a commit
that referenced
this pull request
Mar 23, 2024
## Related Issue/PR #2416 cc @keith ## Modification Update example's Info.plist file. > Open the newly created file and paste in it the contents found in this [example Info.plist file](https://github.com/bazelbuild/rules_apple/blob/master/examples/ios/HelloWorldSwift/Info.plist). The [tutorial](https://github.com/bazelbuild/rules_apple/blob/master/doc/tutorials/ios-app.md) guide us to use the Info.plist file here. But it lacks some information and will make the ipa binary to launch as compatible mode of legacy iOS app. ## Description Before the PR:  After the PR:  ## Test You can verify the behavior by running the [tutorial](https://github.com/bazelbuild/rules_apple/blob/master/doc/tutorials/ios-app.md). Or Once we delete the extra `launch_storyboard = "//examples/resources:Launch.storyboard"` in `HelloWorldSwift`. We can also reproduce it by running the following commands ```shell cd ${PROJECT_ROOT}/examples/ios/HelloWorldSwift # If you are running a stable bazel, you can `rm ${PROJECT_ROOT}/.bazelversion` to workaround the error bazel run //examples/ios/HelloWorldSwift:HelloWorldSwift ```
acecilia
pushed a commit
to revolut-mobile/rules_apple
that referenced
this pull request
Apr 12, 2024
acecilia
pushed a commit
to revolut-mobile/rules_apple
that referenced
this pull request
Apr 12, 2024
## Related Issue/PR bazelbuild#2416 cc @keith ## Modification Update example's Info.plist file. > Open the newly created file and paste in it the contents found in this [example Info.plist file](https://github.com/bazelbuild/rules_apple/blob/master/examples/ios/HelloWorldSwift/Info.plist). The [tutorial](https://github.com/bazelbuild/rules_apple/blob/master/doc/tutorials/ios-app.md) guide us to use the Info.plist file here. But it lacks some information and will make the ipa binary to launch as compatible mode of legacy iOS app. ## Description Before the PR:  After the PR:  ## Test You can verify the behavior by running the [tutorial](https://github.com/bazelbuild/rules_apple/blob/master/doc/tutorials/ios-app.md). Or Once we delete the extra `launch_storyboard = "//examples/resources:Launch.storyboard"` in `HelloWorldSwift`. We can also reproduce it by running the following commands ```shell cd ${PROJECT_ROOT}/examples/ios/HelloWorldSwift # If you are running a stable bazel, you can `rm ${PROJECT_ROOT}/.bazelversion` to workaround the error bazel run //examples/ios/HelloWorldSwift:HelloWorldSwift ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2414