Fix dynamic framework lipo issue #2398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when a dynamic framework was lipo'd and then bitcode stripped, the bitcode stripping would replace the lipo'd binary and you'd end up with a binary that contained more architectures than were requested. Fixes #2392
|
Want to do the apple_support bump in a separate change? |
mattrobmattrob
approved these changes
Feb 9, 2024
|
We can't separate that bump because otherwise the test fails for something that was previously covered up by this bug |
|
Good deal, merge away! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously when a dynamic framework was lipo'd and then bitcode
stripped, the bitcode stripping would replace the lipo'd binary and
you'd end up with a binary that contained more architectures than were
requested.
Fixes #2392