-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DWARF binary not copied for AppleDsymBundleInfo #2396
Merged
luispadron
merged 1 commit into
master
from
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
Feb 24, 2024
Merged
Fix DWARF binary not copied for AppleDsymBundleInfo #2396
luispadron
merged 1 commit into
master
from
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
Feb 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luispadron
force-pushed
the
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
branch
from
February 8, 2024 20:06
1fb68e3
to
97880f8
Compare
luispadron
commented
Feb 8, 2024
luispadron
force-pushed
the
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
branch
2 times, most recently
from
February 16, 2024 16:51
8105457
to
dbed722
Compare
luispadron
requested review from
BalestraPatrick,
brentleyjones,
keith,
mattrobmattrob and
thii
as code owners
February 16, 2024 16:52
luispadron
force-pushed
the
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
branch
3 times, most recently
from
February 23, 2024 01:49
7a56973
to
52f159f
Compare
mattrobmattrob
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to add a test for this?
luispadron
force-pushed
the
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
branch
from
February 23, 2024 15:40
daad6f0
to
574ebdd
Compare
@mattrobmattrob updated and added tests for the xcarchive rule to ensure these are now getting copied (these tests were previously failing without this change) |
luispadron
force-pushed
the
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
branch
from
February 23, 2024 15:50
574ebdd
to
04e5f2f
Compare
luispadron
force-pushed
the
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
branch
from
February 23, 2024 22:23
04e5f2f
to
17c1b80
Compare
Co-authored-by: Matt Robinson <mattrob@hey.com>
luispadron
force-pushed
the
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
branch
from
February 24, 2024 00:18
17c1b80
to
e1ce241
Compare
luispadron
deleted the
luis/fix-dsym-dwarf-binary-not-copied-to-appledsyminfoprovider
branch
February 24, 2024 00:35
acecilia
pushed a commit
to revolut-mobile/rules_apple
that referenced
this pull request
Apr 12, 2024
From what I can tell the `AppleDebugInfo` provider correctly gives us the binary paths, the only difference is that `AppleDsymBundleInfo` seems to add a `/dSYMS/` directory path. This PR updates to copy to the dwarf binaries the correct `/dSYMS/` as well. Co-authored-by: Matt Robinson <mattrob@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell the
AppleDebugInfo
provider correctly gives us the binary paths, the only difference is thatAppleDsymBundleInfo
seems to add a/dSYMS/
directory path:It looks like thats intentional given:
rules_apple/apple/internal/partials/debug_symbols.bzl
Lines 330 to 332 in afd97b7
But then the rule copies it without the
/dSYMS
:rules_apple/apple/internal/partials/debug_symbols.bzl
Lines 132 to 137 in afd97b7
Before:
After: