Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with experimental_mixed_language_library header map #2390

Merged

Conversation

luispadron
Copy link
Contributor

Fixes some issues I ran into while integrating on a more real project than the examples:

  • includes is a frozen list after kwargs.pop, use [] + kwargs.pop to allow mutation within the macro.
  • objc_copts and append do not work when objc_copts is a select. Use += to add a default list of copts to any list or select
  • Add testonly support to header_map_support

@luispadron luispadron force-pushed the luis/fix-experimental-mixed-language-library-issues branch from 333e003 to 60f0116 Compare January 25, 2024 07:25
@luispadron luispadron force-pushed the luis/fix-experimental-mixed-language-library-issues branch from 60f0116 to 1c77018 Compare January 25, 2024 07:27
@luispadron luispadron marked this pull request as ready for review January 25, 2024 15:32
@luispadron luispadron merged commit 9a785ca into master Jan 25, 2024
10 checks passed
@luispadron luispadron deleted the luis/fix-experimental-mixed-language-library-issues branch January 25, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants