Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _xcrunwrapper #2208

Closed
wants to merge 1 commit into from
Closed

Remove _xcrunwrapper #2208

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions apple/internal/rule_attrs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,17 +170,6 @@ def _j2objc_binary_linking_attrs(*, deps_cfg):
cfg = "exec",
default = Label("@bazel_tools//tools/objc:j2objc_dead_code_pruner_binary"),
),
# xcrunwrapper is no longer used by rules_apple, but the underlying implementation of
# apple_common.link_multi_arch_binary and j2objc_dead_code_pruner require this attribute.
# See CompilationSupport.java:
# - `registerJ2ObjcDeadCodeRemovalActions()`
# - `registerLinkActions()` --> `registerBinaryStripAction()`
# TODO(b/117932394): Remove this attribute once Bazel no longer uses xcrunwrapper.
"_xcrunwrapper": attr.label(
cfg = "exec",
executable = True,
default = Label("@bazel_tools//tools/objc:xcrunwrapper"),
),
}

def _static_library_linking_attrs(*, deps_cfg):
Expand Down