Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip --incompatible_objc_linking_info_migration back for now #1813

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Flip --incompatible_objc_linking_info_migration back for now #1813

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cd83173
Flip `--incompatible_objc_linking_info_migration` back for now
thii Jan 26, 2023
d985452
Only flip for `last_green` jobs
thii Jan 26, 2023
b5bf0ab
Add to common test flags for last_green
thii Jan 26, 2023
3acd089
Revert unrelated change
thii Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ x_defaults:
- "tools/..."
- "test/..."
- "examples/..."
common_last_green: &common_last_green
build_flags:
# https://github.com/bazelbuild/bazel/issues/16939
- --incompatible_objc_linking_info_migration=false
test_flags:
- --incompatible_objc_linking_info_migration=false

# NOTE: To avoid listing the same things for build_flags/test_flags for each
# of these tasks, they are listed in the .bazelrc instead.
Expand All @@ -33,6 +39,7 @@ tasks:
name: "Last Green Bazel"
bazel: last_green
<<: *common
<<: *common_last_green

macos_last_green_head_deps:
name: "Last Green Bazel with Head Deps"
Expand All @@ -42,12 +49,14 @@ tasks:
# has landed on them breaking this project.
- .bazelci/update_workspace_to_deps_heads.sh
<<: *common
<<: *common_last_green

doc_tests:
name: "Doc tests"
bazel: last_green
platform: ubuntu2004
test_targets:
- "doc/..."
<<: *common_last_green

buildifier: latest