Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

missing com_google_cloud_sdk #90

Open
thehesiod opened this issue Nov 5, 2018 · 5 comments
Open

missing com_google_cloud_sdk #90

thehesiod opened this issue Nov 5, 2018 · 5 comments

Comments

@thehesiod
Copy link
Contributor

I tried updating google/upvote to use 0.0.8 but then ran into:
/monolith_binary.deploy: line 26: ${{TMPDIR:-/tmp}}/war.XXXXXXXX: bad substitution
presumably due to double curly braces that seems to be fixed in the latest release.

Using head I get:
upvote/gae/BUILD:15:1: no such package '@com_google_cloud_sdk//': The repository could not be resolved and referenced by '//upvote/gae:monolith_binary.deploy'

@thehesiod
Copy link
Contributor Author

thehesiod commented Nov 5, 2018

ah, looks like I had to add:

load(
    "@io_bazel_rules_appengine//appengine:sdk.bzl",
    "appengine_repositories",
)

appengine_repositories()

may be worth mentioning in docs for post 0.0.8?

@thehesiod
Copy link
Contributor Author

found another issue, on this line: https://github.com/bazelbuild/rules_appengine/blob/master/appengine/py/appengine_deploy.sh.template#L26

TMPDIR ends with a slash on my system, so you get a double slash, and a subsequent error because it can't find the directory. I fixed this on my system like so:

tmp_dir=$(echo ${TMPDIR:-/tmp}/war.XXXXXXXX | tr -s /)
tmp_dir="$(mktemp -d "${tmp_dir}")"

still have another error deploying, investigating

@thehesiod
Copy link
Contributor Author

thehesiod commented Nov 6, 2018

so now it seems like the requests_toolbelt.adapters is not getting loaded

update: I had to set overwrite_appengine_config = False, worth documenting as well for backwards compatibility

@pmbethe09
Copy link
Member

If this investigation leads to some bug fixes, please send me a PR

thehesiod added a commit to thehesiod-forks/rules_appengine that referenced this issue Nov 12, 2018
@thehesiod
Copy link
Contributor Author

let me know what you guys think: #91

pmbethe09 pushed a commit that referenced this issue Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants