Do not append \n for PROCESS since that output has all of the delim…
#7146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iters and can be chunked not per line.
dkashyn-sfdc
commented
Dec 10, 2024
| @@ -237,19 +237,17 @@ void println(PrintOutput output) { | |||
| } | |||
|
|
|||
| private void println(String text, OutputType outputType) { | |||
| if (outputType == OutputType.PROCESS) { | |||
There was a problem hiding this comment.
I think this was an attempt to not have extra \n and there are few reasons to trim the output of the process otherwise.
dkashyn-sfdc
commented
Dec 10, 2024
| outputType == OutputType.ERROR | ||
| ? ConsoleViewContentType.ERROR_OUTPUT | ||
| : ConsoleViewContentType.NORMAL_OUTPUT); | ||
| if (outputType != OutputType.PROCESS) { |
There was a problem hiding this comment.
Using separators "as is" for the process and adding potentially omitted ones for other output types.
|
can we close this #7145 now? |
Yes! |
ujohnny
added a commit
to ujohnny/intellij
that referenced
this pull request
Dec 17, 2024
…iters and can be chunked not per line. (bazelbuild#7146) (cherry picked from commit f5f8f24)
mai93
pushed a commit
that referenced
this pull request
Dec 17, 2024
* fixed bug where bazel runs with curses when using the old sync view (#7139) The old sync view does not use a pty based terminal and cannot handle bazel output correctly when it runs with curses. (cherry picked from commit 0fb3f81) * fixed bug where bazel automatically enables curses (#7143) Bazel is still run using a PtyCommandLine and seems to automatically enable curses when using the old sync view. (cherry picked from commit 2bea8d9) * Do not append `\n` for PROCESS since that output has all of the delimiters and can be chunked not per line. (#7146) (cherry picked from commit f5f8f24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…iters and can be chunked not per line.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: 7145
Description of this change