fix: remove strongInfoHolder flag, so users can choose which plugin t… #7092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jastice
reviewed
Dec 2, 2024
| @@ -67,7 +67,7 @@ public class AutoImportProjectOpenProcessor extends ProjectOpenProcessor { | |||
| public @NotNull | |||
| @Nls | |||
| String getName() { | |||
| return Blaze.defaultBuildSystemName() + " Project"; | |||
| return "Bazel (OG)"; | |||
There was a problem hiding this comment.
OG is kind of internal terminology, let's consider if there is a more clear name. On the other hand, none of "native", "Google", "old" are clear names either :/
jastice
approved these changes
Dec 2, 2024
xuansontrinh
approved these changes
Dec 2, 2024
hb-man
pushed a commit
to JetBrains/hirschgarten
that referenced
this pull request
Dec 2, 2024
To differentiate from the original Bazel plugin during the EAP phase, the display name now includes "(EAP)" in the import process. This change ensures users can distinguish between different versions if they have both installed. See also: bazelbuild/intellij#7092
hb-man
pushed a commit
to JetBrains/hirschgarten
that referenced
this pull request
Dec 2, 2024
This disabler is mostly obsolete now that the OG plugin no longer hijacks the import process: bazelbuild/intellij#7092 #BAZEL-1523 fixed This reverts commit 36b4d64.
dkashyn-sfdc
pushed a commit
to dkashyn-sfdc/intellij
that referenced
this pull request
Dec 2, 2024
bazelbuild#7092) * fix: remove strongInfoHolder flag, so users can choose which plugin to use on import * Update AutoImportProjectOpenProcessor.java * Update BlazeProjectOpenProcessor.java
hb-man
pushed a commit
to JetBrains/hirschgarten
that referenced
this pull request
Dec 3, 2024
…L-1523 Done This disabler is mostly obsolete now that the OG plugin no longer hijacks the import process: bazelbuild/intellij#7092
hb-man
pushed a commit
to JetBrains/hirschgarten
that referenced
this pull request
Dec 11, 2024
…L-1523 Done This disabler is mostly obsolete now that the OG plugin no longer hijacks the import process: bazelbuild/intellij#7092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…o use on import
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change