[AOSP-pick] Use BuildArtifactCache to fetch -info.txt files #7024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetching multiple info files sequentially is slow especially whey they are enormous in size. (The total size reaching 6gb+). Instead fetch artifacts through the `BuildArtifactCache` which already handles parallel and asynchronous downloading well. Also, remove the `qsync.parallel.artifact.info.fetch` experiment as it not longer controls anything. Info files are not different to other artifacts and thus the same mode that works for other artifacts should work for info files. Bug: n/a Test: n/a Change-Id: I6f023154ca318af390956e78678dc899a359d31d AOSP: 9c2f4c7143874defeb9cb9c69f69168975f38d5b
d289d97 to
84c5be3
Compare
tpasternak
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick AOSP commit 9c2f4c7143874defeb9cb9c69f69168975f38d5b.
Fetching multiple info files sequentially is slow especially whey they
are enormous in size. (The total size reaching 6gb+).
Instead fetch artifacts through the
BuildArtifactCachewhich alreadyhandles parallel and asynchronous downloading well.
Also, remove the
qsync.parallel.artifact.info.fetchexperiment as itnot longer controls anything. Info files are not different to other
artifacts and thus the same mode that works for other artifacts should
work for info files.
Bug: n/a
Test: n/a
Change-Id: I6f023154ca318af390956e78678dc899a359d31d
AOSP: 9c2f4c7143874defeb9cb9c69f69168975f38d5b