-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PTY enabled terminal for the new sync view #7001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeFrosch
force-pushed
the
sync-view-pty
branch
2 times, most recently
from
November 18, 2024 16:59
2959a8a
to
0b329a5
Compare
LeFrosch
requested review from
mai93,
tpasternak and
agluszak
as code owners
November 18, 2024 17:29
github-actions
bot
added
product: CLion
CLion plugin
product: IntelliJ
IntelliJ plugin
product: GoLand
GoLand plugin
awaiting-review
Awaiting review from Bazel team on PRs
labels
Nov 18, 2024
# Conflicts: # base/src/com/google/idea/blaze/base/command/BuildFlagsProviderImpl.java
LeFrosch
force-pushed
the
sync-view-pty
branch
from
November 22, 2024 14:04
f0b61b8
to
be1783e
Compare
Rebased master |
LeFrosch
force-pushed
the
sync-view-pty
branch
from
November 22, 2024 14:28
9762492
to
cdc2020
Compare
Since the terminal width is final in bazel there is no use for propagating resize events to the bazel process.
LeFrosch
force-pushed
the
sync-view-pty
branch
from
November 22, 2024 15:21
cdc2020
to
a571745
Compare
|
ujohnny
approved these changes
Nov 29, 2024
github-actions
bot
removed
the
awaiting-review
Awaiting review from Bazel team on PRs
label
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of this change
In order to get all the relevant information form bazel it has to be executed with
--curses=yes
and connected to a pty enabled terminal. This shows use full information like the download progress.