Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTY enabled terminal for the new sync view #7001

Merged
merged 6 commits into from
Nov 30, 2024

Conversation

LeFrosch
Copy link
Collaborator

Description of this change

In order to get all the relevant information form bazel it has to be executed with --curses=yes and connected to a pty enabled terminal. This shows use full information like the download progress.

@LeFrosch LeFrosch force-pushed the sync-view-pty branch 2 times, most recently from 2959a8a to 0b329a5 Compare November 18, 2024 16:59
@LeFrosch LeFrosch marked this pull request as ready for review November 18, 2024 17:29
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Nov 18, 2024
@ujohnny
Copy link
Collaborator

ujohnny commented Nov 21, 2024

this looks really nice, would it be possible to make pty respect viewport size?

image

# Conflicts:
#	base/src/com/google/idea/blaze/base/command/BuildFlagsProviderImpl.java
@LeFrosch
Copy link
Collaborator Author

Rebased master

Since the terminal width is final in bazel there is no use for propagating resize events to the bazel process.
@ujohnny
Copy link
Collaborator

ujohnny commented Nov 23, 2024

base/src/com/google/idea/blaze/base/buildview/PtyConsoleView.kt:50:9: warning: name shadowed: text
    var text = text.trimEnd()
        ^^^^
base/src/com/google/idea/blaze/base/buildview/PtyConsoleView.kt:50:9: warning: name shadowed: text
    var text = text.trimEnd()
        ^^^^

@LeFrosch LeFrosch merged commit c75b165 into bazelbuild:master Nov 30, 2024
5 checks passed
@LeFrosch LeFrosch deleted the sync-view-pty branch November 30, 2024 12:43
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

4 participants