Test protobuf on Windows #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
added a commit
that referenced
this pull request
Jan 2, 2019
I recently enabled protobuf test on Windows at #427 But it is failing on CI while succeeded on my local machine: https://buildkite.com/bazel/protobuf/builds/1947#b3bb6708-ef5d-4d36-a5d6-a52e45d78e51 It turned out it's the line endings are automatically transformed to `\r\n` when cloning with Git on Windows (I'm using git in msys on my machine). Thus, we need to turn off the auto-translation to allow the test to pass.
philwo
pushed a commit
that referenced
this pull request
Jan 3, 2019
I recently enabled protobuf test on Windows at #427 But it is failing on CI while succeeded on my local machine: https://buildkite.com/bazel/protobuf/builds/1947#b3bb6708-ef5d-4d36-a5d6-a52e45d78e51 It turned out it's the line endings are automatically transformed to `\r\n` when cloning with Git on Windows (I'm using git in msys on my machine). Thus, we need to turn off the auto-translation to allow the test to pass.
joeleba
pushed a commit
to joeleba/continuous-integration
that referenced
this pull request
Jun 17, 2019
joeleba
pushed a commit
to joeleba/continuous-integration
that referenced
this pull request
Jun 17, 2019
…zelbuild#433) I recently enabled protobuf test on Windows at bazelbuild#427 But it is failing on CI while succeeded on my local machine: https://buildkite.com/bazel/protobuf/builds/1947#b3bb6708-ef5d-4d36-a5d6-a52e45d78e51 It turned out it's the line endings are automatically transformed to `\r\n` when cloning with Git on Windows (I'm using git in msys on my machine). Thus, we need to turn off the auto-translation to allow the test to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked by protocolbuffers/protobuf#5470