-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gerrit unflip enable bzlmod option #1804
Gerrit unflip enable bzlmod option #1804
Conversation
Actually this shouldn't be needed, once this CL is merged. |
We should wait with merging this, I will upload an updated version of this PR. |
b52e3b8
to
812e3fe
Compare
Closes bazelbuild#1072. We have seen multiple breakages on RBE platforms and modern C++ toolchains. To prevent potential breakages and/or to detect them earlier we are adding those new platforms to the gerrit pipeline.
812e3fe
to
b4f910e
Compare
Turns out SSH and Git Protocol V2 tests require some special setting, that complicates things on Bazel CI, see: I think it's much simpler to take those tests out of the picture on Bazel CI, as trying to fix them. I've sent you this CL for review. Could you please review it? Thanks! |
@meteorcloudy we clarified the problem with Could you please look at RBE build breakage? I'm not sure I understand it: https://buildkite.com/bazel/gerrit/builds/12729#018c15cd-c426-46d9-a8b0-a79c4924240c It seems, that outdated options pulled in on this platform? Should we try to fix it, or should I removed RBE-platform again on Bazel-CI@Buildkite. We are using RBE@GCP downstream without any issue for years now... |
It's from the bazelci.py script, there is some recent change to update the flag names, but was rollbacked for some reason. @fweikert The logic is here: continuous-integration/buildkite/bazelci.py Lines 2027 to 2034 in 387688a
|
@meteorcloudy Thanks for the pointer. I filed this issue for this platform and will remove it for now for gerrit pipeline, and reconsider to re-add the build on RBE platform later, once it's fixed. |
No description provided.