Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gerrit unflip enable bzlmod option #1804

Merged

Conversation

davido
Copy link
Contributor

@davido davido commented Nov 18, 2023

No description provided.

@davido
Copy link
Contributor Author

davido commented Nov 18, 2023

Actually this shouldn't be needed, once this CL is merged.

@davido
Copy link
Contributor Author

davido commented Nov 20, 2023

We should wait with merging this, I will upload an updated version of this PR.

@davido davido marked this pull request as draft November 20, 2023 10:50
@davido davido force-pushed the gerrit-unflip-enable_bzlmod-option branch from b52e3b8 to 812e3fe Compare November 22, 2023 17:08
Closes bazelbuild#1072.

We have seen multiple breakages on RBE platforms and modern C++
toolchains. To prevent potential breakages and/or to detect them
earlier we are adding those new platforms to the gerrit pipeline.
@davido davido force-pushed the gerrit-unflip-enable_bzlmod-option branch from 812e3fe to b4f910e Compare November 22, 2023 20:48
@davido davido marked this pull request as ready for review November 22, 2023 20:48
@meteorcloudy meteorcloudy merged commit e99d8b0 into bazelbuild:master Nov 23, 2023
1 check passed
@davido davido deleted the gerrit-unflip-enable_bzlmod-option branch November 23, 2023 22:24
@davido
Copy link
Contributor Author

davido commented Nov 23, 2023

@meteorcloudy

Turns out SSH and Git Protocol V2 tests require some special setting, that complicates things on Bazel CI, see:
https://buildkite.com/bazel/gerrit/builds/12701#018bfdc5-4521-4eb1-b4c5-8771b19b5617

I think it's much simpler to take those tests out of the picture on Bazel CI, as trying to fix them.

I've sent you this CL for review.

Could you please review it? Thanks!

@davido
Copy link
Contributor Author

davido commented Nov 28, 2023

@meteorcloudy we clarified the problem with openssh-client.

Could you please look at RBE build breakage? I'm not sure I understand it:

https://buildkite.com/bazel/gerrit/builds/12729#018c15cd-c426-46d9-a8b0-a79c4924240c

It seems, that outdated options pulled in on this platform?
I don't know how/where to fix it?

Should we try to fix it, or should I removed RBE-platform again on Bazel-CI@Buildkite.

We are using RBE@GCP downstream without any issue for years now...

@meteorcloudy
Copy link
Member

It's from the bazelci.py script, there is some recent change to update the flag names, but was rollbacked for some reason. @fweikert
#1811

The logic is here:

for platform_flag, value in list(platform_flags.items()):
found = False
for original_flag in original_flags:
if original_flag.startswith(platform_flag):
found = True
break
if not found:
flags += [platform_flag + "=" + value]

@davido
Copy link
Contributor Author

davido commented Nov 28, 2023

@meteorcloudy Thanks for the pointer. I filed this issue for this platform and will remove it for now for gerrit pipeline, and reconsider to re-add the build on RBE platform later, once it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants