Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flipped a flag 'incompatible_tls_enabled_removed' #9062

Closed
wants to merge 3 commits into from

Conversation

ishikhman
Copy link
Contributor

Set --incompatible_tls_enabled_removed to true by default.

RELNOTES: by default all remote connections considered to be via gRPC with TLS enabled, unless other specified. To disable TLS use grpc:// prefix for you endpoints. All remote connections via gRPC affected - --remote_cache, --remote_executor or --bes_backend. http cache/executor is not affected. See #8061 for details.

Fixes #8061.

@buchgr
Copy link
Contributor

buchgr commented Aug 5, 2019

It's too late to flip this flag since 0.29 has already been cut. Next flag flip window will be in March 2020 :'(

@ishikhman
Copy link
Contributor Author

ishikhman commented Aug 5, 2019

I've decided to keep both --incompatible_tls_enabled_removed and --tls_enabled as deprecated and no-op for some time to keep migration smoother and avoid breakage of the builds when one or both flags are still present.

Quite a few projects will be broken according to Bazelisk if we just flip a flag: https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/200

Therefore I've flipped a flag and made both flags (incompatible flag and the one to be removed) no-op and deprecated. In this way build will not fail for the projects which are using a flag AND will show a deprecation warning instead. Therefore the risk of breakage would be really low.

PS: I've double checked - all the downstreams that were broken in Bazelisk were broken because 'tls_enabled=true' was used.

@bazel-io bazel-io closed this in d2de8ee Aug 7, 2019
@ishikhman
Copy link
Contributor Author

As of https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1131 no breakage for downstream projects deteceted after merge.

@ishikhman ishikhman deleted the flip-flag-tls branch August 8, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

incompatible_tls_enabled_removed: flip it and enable tls by default while deprecating tls_enabled flag
4 participants