Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add key and reverse parameters to builtin sorted function #8881

Closed
wants to merge 6 commits into from
Closed

Add key and reverse parameters to builtin sorted function #8881

wants to merge 6 commits into from

Conversation

Quarz0
Copy link
Contributor

@Quarz0 Quarz0 commented Jul 12, 2019

@laurentlb
Copy link
Contributor

cc @alandonovan, fyi

alandonovan
alandonovan reviewed Jul 12, 2019
View reviewed changes
Copy link
Contributor

@alandonovan alandonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this feature.

src/main/java/com/google/devtools/build/lib/syntax/EvalUtils.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
@Quarz0
Copy link
Contributor Author

Quarz0 commented Jul 13, 2019

I made the requested changes.

alandonovan
alandonovan reviewed Jul 15, 2019
View reviewed changes
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
alandonovan
alandonovan approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@alandonovan alandonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with these last changes.

src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java Outdated Show resolved Hide resolved
@laurentlb
Copy link
Contributor

@vladmos please import the change when/if it's ready

@bazel-io bazel-io closed this in cc2c4ee Jul 16, 2019
bazel-io pushed a commit that referenced this pull request Jul 16, 2019
@copybara-github
bazel syntax: simplify implementation of sorted function
327bd66 
I failed to notice in the GitHub review
(github.com//pull/8881)
that the function had redundant checks and parameters.

PiperOrigin-RevId: 258443310
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alandonovan alandonovan alandonovan approved these changes

@laurentlb laurentlb Awaiting requested review from laurentlb

@vladmos vladmos Awaiting requested review from vladmos

Assignees

@vladmos vladmos

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Quarz0 @laurentlb @alandonovan @vladmos @googlebot