Flip --incompatible_windows_escape_python_args #8478
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI test results (Bazel@HEAD + Downstream): https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1003 The flag affects Windows only, and on Windows only two projects are broken: rules_foreign_cc and rules_nodejs. These are also broken on other platforms, and in the previous build: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1002 Therefore I'm reasonably sure they are not broken by this PR. That said, we can't completely be sure because the tests didn't run. See bazelbuild#7974 Change-Id: I2cc09a4e9295495062dc4ac79b859dec6512b1b7
meteorcloudy
approved these changes
May 28, 2019
|
Thanks @meteorcloudy ! Also waiting for @brandjon to LGTM. |
brandjon
approved these changes
May 28, 2019
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
CI test results (Bazel@HEAD + Downstream): https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1003 The flag affects Windows only, and on Windows only two projects are broken: rules_foreign_cc and rules_nodejs. These are also broken on other platforms, and in the previous build: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1002 Therefore I'm reasonably sure they are not broken by this PR. That said, we can't completely be sure because the tests didn't run. See bazelbuild#7974 Change-Id: I2cc09a4e9295495062dc4ac79b859dec6512b1b7 Closes bazelbuild#8478. Change-Id: I2cc09a4e9295495062dc4ac79b859dec6512b1b7 PiperOrigin-RevId: 250437116
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jul 15, 2019
CI test results (Bazel@HEAD + Downstream): https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1003 The flag affects Windows only, and on Windows only two projects are broken: rules_foreign_cc and rules_nodejs. These are also broken on other platforms, and in the previous build: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1002 Therefore I'm reasonably sure they are not broken by this PR. That said, we can't completely be sure because the tests didn't run. See bazelbuild#7974 Change-Id: I2cc09a4e9295495062dc4ac79b859dec6512b1b7 Closes bazelbuild#8478. Change-Id: I2cc09a4e9295495062dc4ac79b859dec6512b1b7 PiperOrigin-RevId: 250437116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI test results (Bazel@HEAD + Downstream):
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1003
The flag affects Windows only, and on Windows only
two projects are broken: rules_foreign_cc and
rules_nodejs.
These are also broken on other platforms, and in
the previous build:
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1002
Therefore I'm reasonably sure they are not broken
by this PR. That said, we can't completely be
sure because the tests didn't run.
See #7974
Change-Id: I2cc09a4e9295495062dc4ac79b859dec6512b1b7