Add jacocorunner to java_toolchain. #8378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6180000 to
95d8fcf
Compare
|
Looks OK. Can you add a test, or migrate existing tests to use the new attribute? |
|
Actually we don't have any open-sourced tests for java_toolchain. I opened #8404 to keep track of open sourcing the tests. For now I added the |
|
@hlopko Can you take a look today? |
This broke in 33f7b77, as the new code path was not handling this case correctly. Fixes bazelbuild#8402. PiperOrigin-RevId: 249201968
ed44034 to
9f4a0da
Compare
9f4a0da to
5e7ad2f
Compare
bazel-io
pushed a commit
that referenced
this pull request
May 22, 2019
Also enable jacocorunner in BUILD.java_tools since #8378 is now merged. RELNOTES: None. PiperOrigin-RevId: 249442764
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
The jacoco runner was previously retrieved via an implicit attribute `$jacocorunner` on the `java_binary` and `java_test` rules. Retrieving the runner via the implicit attribute makes testing the tools in the `java_tools` release difficult and inconsistent (almost all other tools are defined via `java_toolchain`). This PR makes `jacocorunner` part of `java_toolchain`. If `jacocorunner` is not found in the toolchain it falls back to the `$jacocorunner` attribute. The fallback behavior can be removed after a bazel release with this change. Closes bazelbuild#8378. PiperOrigin-RevId: 249241175
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
BranchDetailAnalyzer should have also been updated as part of bazelbuild@ff1f745 when the jacoco version in bazel was updated. Changes like this will be avoided after bazelbuild#8378 is merged, because it enables testing with the java coverage tools at head. Closes bazelbuild#8417. PiperOrigin-RevId: 249400130
irengrig
pushed a commit
to irengrig/bazel
that referenced
this pull request
Jun 18, 2019
Also enable jacocorunner in BUILD.java_tools since bazelbuild#8378 is now merged. RELNOTES: None. PiperOrigin-RevId: 249442764
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The jacoco runner was previously retrieved via an implicit attribute
$jacocorunneron thejava_binaryandjava_testrules. Retrieving the runner via the implicit attribute makes testing the tools in thejava_toolsrelease difficult and inconsistent (almost all other tools are defined viajava_toolchain).This PR makes
jacocorunnerpart ofjava_toolchain. Ifjacocorunneris not found in the toolchain it falls back to the$jacocorunnerattribute. The fallback behavior can be removed after a bazel release with this change.