Rename ToolchainResolutionFunction to SingleToolchainResolutionFunction. #8065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of work on execution transitions, bazelbuild#7935.
gregestren
approved these changes
Apr 16, 2019
| * type. Callers will need to consider all toolchain types that are required and merge the results | ||
| * together appropriately. | ||
| * A value which represents the map of potential execution platforms and resolved toolchains for a | ||
| * single toolchain type.This allows for a Skyframe cache per toolchain type. |
There was a problem hiding this comment.
typo nit: space after period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of work on execution transitions, #7935.