Windows, native launcher: use C++ runfiles library #7853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this PR: - //src/tools/launcher now uses the C++ runfiles library, depending on it's source and not on the released version under @bazel_tools (so it's built with the same runfiles library sources as those embedded into the Bazel binary) - The launcher no longer discovers nor loads the runfiles manifest. Fixes bazelbuild#7809
| } | ||
| query_path += L"/" + path; | ||
| return query_path; | ||
| if (path.find(L"external/") == 0) { |
There was a problem hiding this comment.
What if users has an external directory in their source tree? This could be wrong. Maybe path.startwith(L"external/") is better? Or just don't check it at all, because <workspace_name>/external/<external_repo_name><file_path_in_external_repo> also exits in manifest file.
There was a problem hiding this comment.
This checks if "external/" is found at index 0, i.e. same as startswith(). There's no startswith() function.
Change-Id: I135892862f7fb2d9f6c0492f2071507d4f14b1d3
Change-Id: I417d90fec446a127793a4ed133e7b1f611240a26
Change-Id: I5439f2012432cc95eca382371b0da7f72155cd58
meteorcloudy
approved these changes
Mar 28, 2019
|
I added d2649fa to fix the Windows tests. |
laszlocsomor
added a commit
to laszlocsomor/bazel
that referenced
this pull request
Mar 28, 2019
The native launcher's own Rlocation() implementation correctly handles runfile paths that start with "external/". Fixes bazelbuild#7809 This PR subsumes bazelbuild#7853. That PR changed the launcher to use the C++ runfiles library. Alas that broke some tests.
|
Redone as #7873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
//src/tools/launcher now uses the C++ runfiles
library, depending on it's source and not on
the released version under @bazel_tools (so it's
built with the same runfiles library sources as
those embedded into the Bazel binary)
The launcher no longer discovers nor loads the
runfiles manifest.
Fixes #7809