remote: properly reset state when using remote cache. Fixes #7555 #7562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d#7555 when using --remote_(http)_cache we wouldn't properly reset the state on the bazel server and so on subsequent command invocations the server would still think it's using remote caching. this would lead for bazel to hang indefinitely.
meisterT
approved these changes
Feb 27, 2019
|
fyi @laurentlb |
meteorcloudy
approved these changes
Feb 27, 2019
laurentlb
pushed a commit
that referenced
this pull request
Feb 28, 2019
when using --remote_(http)_cache we wouldn't properly reset the state on the bazel server and so on subsequent command invocations the server would still think it's using remote caching. this would lead for bazel to hang indefinitely. Closes #7562. PiperOrigin-RevId: 235914044
laurentlb
pushed a commit
that referenced
this pull request
Mar 7, 2019
when using --remote_(http)_cache we wouldn't properly reset the state on the bazel server and so on subsequent command invocations the server would still think it's using remote caching. this would lead for bazel to hang indefinitely. Closes #7562. PiperOrigin-RevId: 235914044
laurentlb
pushed a commit
that referenced
this pull request
Mar 7, 2019
when using --remote_(http)_cache we wouldn't properly reset the state on the bazel server and so on subsequent command invocations the server would still think it's using remote caching. this would lead for bazel to hang indefinitely. Closes #7562. PiperOrigin-RevId: 235914044
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using --remote_(http)_cache we wouldn't properly reset the state on
the bazel server and so on subsequent command invocations the server
would still think it's using remote caching. this would lead for bazel
to hang indefinitely.