Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the embedded java tools from the bazel binary. #7472

Closed
wants to merge 6 commits into from
Closed

Remove the embedded java tools from the bazel binary. #7472

wants to merge 6 commits into from

Conversation

iirina
Copy link
Contributor

@iirina iirina commented Feb 20, 2019 •
edited
Loading

The flags that enable using remote Java tools by default were pushed in 4d935d5.

This PR shrinks the bazel binary by ~25%.

To measure the binary sizes I used bazel build -c opt //src:bazel at a57c879 with and without the changes in this PR:

$ ls -lh ~/bazel-with-java-tools | awk '{print $5}'
141M
$ ls -lh ~/bazel-no-java-tools | awk '{print $5}'
105M

Progress on #6316.

@iirina iirina requested a review from meisterT February 20, 2019 09:29
@meisterT
Copy link
Member

Nice! How much does this save? Perhaps include numbers in the commit message.

@iirina
Copy link
Contributor Author

iirina commented Feb 20, 2019

Thanks! It reduces the binary size by 25%, I added some numbers in the initial comment.

I'll first import the third-party changes and then the bazel src/BUILD file.

@meisterT
Copy link
Member

happy dance

@iirina
Copy link
Contributor Author

iirina commented Feb 20, 2019

cc @lberki

bazel-io pushed a commit that referenced this pull request Feb 20, 2019
@iirina
Stop embedding the java tools into the bazel binary.
714e3f2 
Partial commit for third_party/*, see #7472.

Signed-off-by: iirina <elenairina@google.com>
@lberki
Copy link
Contributor

lberki commented Feb 20, 2019

/happydance

@iirina
Copy link
Contributor Author

iirina commented Feb 20, 2019

third_party changes merged in 714e3f2

@bazel-io bazel-io closed this in c33ae8a Feb 21, 2019
@iirina iirina mentioned this pull request Feb 21, 2019
Closed
bazel-io pushed a commit that referenced this pull request Feb 21, 2019
@iirina @copybara-github
Remove third_party/java/langtools from the bazel binary.
6de89a8 
This was part of #7472 but was reverted by mistake by 9192ee3

The bazel binary gets down to 94M. 😃

Progress on #6316.

Closes #7492.

PiperOrigin-RevId: 235003109
@philwo philwo deleted the remove-java-tools-from-binary branch June 20, 2019 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iirina @meisterT @lberki @googlebot