Vendor jaxb library in our third_party. #7240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a64fd25 to
09aab11
Compare
We want to upgrade the embedded JDK to version 11 (see bazelbuild#6592). However, some Java EE modules were removed from 10 to 11: http://openjdk.java.net/jeps/320 From these modules, we need java.xml.bind for the android_common dependency which is used by the android_sdk_repository rule. This will be starlark-ified some time in the future and then will also move the tools to an external repository making it possible to remove this and the android_common dependency from Bazel. But since the migration is not imminent, this commit is the work around to unblock the upgrade to JDK11. RELNOTES: None
bazel-io
pushed a commit
that referenced
this pull request
Jan 28, 2019
We want to upgrade the embedded JDK to version 11 (see #6592). However, some Java EE modules were removed from 10 to 11: http://openjdk.java.net/jeps/320 From these modules, we need java.xml.bind for the android_common dependency which is used by the android_sdk_repository rule. This will be starlark-ified some time in the future and then will also move the tools to an external repository making it possible to remove this and the android_common dependency from Bazel. But since the migration is not imminent, this commit is the work around to unblock the upgrade to JDK11. RELNOTES: None Partial commit for third_party/*, see #7240. Signed-off-by: Philipp Wollermann <philwo@google.com>
bazel-io
pushed a commit
that referenced
this pull request
Jan 28, 2019
We cannot submit third_party changes with changes outside of third_party. RELNOTES: None PiperOrigin-RevId: 231215265
weixiao-huang
pushed a commit
to weixiao-huang/bazel
that referenced
this pull request
Jan 31, 2019
We want to upgrade the embedded JDK to version 11 (see bazelbuild#6592). However, some Java EE modules were removed from 10 to 11: http://openjdk.java.net/jeps/320 From these modules, we need java.xml.bind for the android_common dependency which is used by the android_sdk_repository rule. This will be starlark-ified some time in the future and then will also move the tools to an external repository making it possible to remove this and the android_common dependency from Bazel. But since the migration is not imminent, this commit is the work around to unblock the upgrade to JDK11. RELNOTES: None Partial commit for third_party/*, see bazelbuild#7240. Signed-off-by: Philipp Wollermann <philwo@google.com>
weixiao-huang
pushed a commit
to weixiao-huang/bazel
that referenced
this pull request
Jan 31, 2019
We cannot submit third_party changes with changes outside of third_party. RELNOTES: None PiperOrigin-RevId: 231215265
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to upgrade the embedded JDK to version 11 (see #6592). However,
some Java EE modules were removed from 10 to 11:
http://openjdk.java.net/jeps/320
From these modules, we need java.xml.bind for the android_common
dependency which is used by the android_sdk_repository rule.
This will be starlark-ified some time in the future and then will also
move the tools to an external repository making it possible to remove
this and the android_common dependency from Bazel. But since the
migration is not imminent, this commit is the work around to unblock the
upgrade to JDK11.
RELNOTES: None