remote: quit early if no remote options specified #7198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If neither remote caching nor remote execution is enabled then quit the remote initialization logic early. The current null check on the RemoteOptions is not sufficient as it only works if a none build command is used. Also, don't create a remote logs directory and don't print an invocation id if remoting is disabled.
ulfjack
approved these changes
Jan 21, 2019
weixiao-huang
pushed a commit
to weixiao-huang/bazel
that referenced
this pull request
Jan 31, 2019
If neither remote caching nor remote execution is enabled then quit the remote initialization logic early. The current null check on the RemoteOptions is not sufficient as it only works if a none build command is used. Also, don't create a remote logs directory and don't print an invocation id if remoting is disabled. Closes bazelbuild#7198. PiperOrigin-RevId: 230573618
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If neither remote caching nor remote execution is enabled then
quit the remote initialization logic early. The current null
check on the RemoteOptions is not sufficient as it only works
if a none build command is used.
Also, don't create a remote logs directory and don't print
an invocation id if remoting is disabled.