Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "darwin" to the list of valid macOS architectures #7151

Closed
wants to merge 3 commits into from
Closed

Add "darwin" to the list of valid macOS architectures #7151

wants to merge 3 commits into from

Conversation

keith
Copy link
Member

@keith keith commented Jan 17, 2019

This is an alternative solution to #7062 that is more backwards compatible

@keith keith mentioned this pull request Jan 17, 2019
Closed
@lberki
Copy link
Contributor

lberki commented Jan 17, 2019

/cc @katre

@lberki lberki removed their request for review January 17, 2019 08:26
@jin jin added the team-Configurability platforms, toolchains, cquery, select(), config transitions label Jan 17, 2019
@keith
Copy link
Member Author

keith commented Jan 17, 2019

Everything is green, looks like we should be good to go here! @katre can you help me land this?

@keith
Copy link
Member Author

keith commented Jan 22, 2019

@katre friendly ping!

@katre
Copy link
Member

katre commented Jan 22, 2019

Yes, I can handle importing this. My apologies for not catching the first time.

@keith
Copy link
Member Author

keith commented Jan 22, 2019

Thanks! No worries!

@bazel-io bazel-io closed this in 5c5baf9 Jan 22, 2019
@keith
Copy link
Member Author

keith commented Jan 22, 2019

Thanks!

@keith keith deleted the ks/darwin-no-arch branch January 22, 2019 21:20
@keith keith mentioned this pull request Jan 23, 2019
Closed
weixiao-huang pushed a commit to weixiao-huang/bazel that referenced this pull request Jan 31, 2019
@keith @weixiao-huang
Add "darwin" to the list of valid macOS architectures
128fe01 
This is an alternative solution to bazelbuild#7062 that is more backwards compatible

Closes bazelbuild#7151.

PiperOrigin-RevId: 230388622
@keith keith mentioned this pull request Feb 7, 2019
Closed
@aragos aragos mentioned this pull request Feb 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergiocampama sergiocampama sergiocampama left review comments

@katre katre katre approved these changes

@hlopko hlopko Awaiting requested review from hlopko

@oquenchil oquenchil Awaiting requested review from oquenchil

@scentini scentini Awaiting requested review from scentini

Assignees
No one assigned
Labels
cla: yes team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@keith @lberki @katre @sergiocampama @jin @googlebot