Move ImportDepsChecker to a checked in deploy jar. #7140
Conversation
| @@ -17,3 +17,8 @@ third_party/java/java_tools/JacocoCoverage_jarjar_deploy.jar | |||
| third_party/java/java_tools/turbine_deploy.jar | |||
| third_party/java/java_tools/turbine_direct_binary_deploy.jar | |||
| third_party/java/java_tools/SingleJar_deploy.jar | |||
|
|
|||
| The following tools were built with bazel 0.21.0 at commit 7f97ed4df69c2d9358a063cc7bb310c615ff6496 by running: | |||
There was a problem hiding this comment.
nit: it's nicer to build all the tools at the same commit, but it's OK to do that once all of them are moved to checked-in deploy jars.
| jars = ["//tools/jdk:ImportDepsChecker_deploy.jar"] | ||
| ) | ||
|
|
||
| java_binary( |
There was a problem hiding this comment.
Technically, this is used only in Android code, but it looks like a useful Java tool, so move on.
|
I still have second thoughts whether to push this or not, since it's only used in the Android rules... I don't think we should mix the tools (it could be problematic when we decouple Android from Bazel as well). |
|
Well, what does it do? According to a Javadoc, "Checker that checks the classes in the input jars have complete dependencies. If not, output the missing dependencies to a file" and it processes jdeps files and it does not contain any logic that would be specific to Android, so it makes sense to put in in tools specific to Java... |
|
Irina, did you discuss with Jin where it should belong? |
|
It should belong to the android tools. I'll leave it up to Jin to come up with a plan to build and embed it in the remote android tools. |
|
I'll look into this alongside #1055. |
instead of embedding the deploy jar that is built when the bazel binary is built.
This comes in preparation for moving the Java tools to remote repositories (see #6316). This checked in jar will be moved to a remote repository and referenced from there.
Moving the Java tools happens in two phases:
This PR addresses the first point for
ImportDepsChecker. Doing the move incrementally this way is safer and allows finding bugs earlier. It also allows moving the Java tools code base out of the bazel repository.We are making this change gradually for each java tool defined in JAVA_TOOLS (found in src/BUILD).