Discontinue building jformatstring from source #4843
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davido I may have misunderstood you, but AFAICT, jFormatString isn't really LGPL but GPL v2 with Classpath exception instead (same as OpenJDK's license, IIRC). Perhaps you could correct me if I'm wrong? :) |
This change stops building jformatstring from the source and consumes the artifacts from Central. As the consequence, the sources are removed from the Bazel tree and we discontinue packaging the sources in Bazel source artifact. GPL v2 with Classpath exception sources have to be still included in third_party:gpl-srcs rule. The source jar is included in this rule, that is used in embeded_tools archive.
5c88962 to
8d7197b
Compare
|
@jbduncan Yes, you are right. I was confused with this rule name: |
|
Hi @iirina, Bazel sheriff here, what's the status of this pull request? It hasn't been updated for more than a week so it'd be good to understand if it's still ongoing or safe to close. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change stops building jformatstring from the source and consumes
the artifacts from Central. As the consequence, the sources are removed
from the Bazel tree and we discontinue packaging the sources in Bazel
source artifact.
GPL v2 with Classpath exception sources have to be still included in
third_party:gpl-srcsrule. The source jar is included in this rule, thatis used in embeded_tools archive.