Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2671 on GitHub #2678

Closed
wants to merge 1 commit into from
Closed

Fix #2671 on GitHub #2678

wants to merge 1 commit into from

Conversation

petemounce
Copy link
Contributor

No description provided.

@bazel-io
Copy link
Member

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

petemounce
petemounce commented Mar 14, 2017
View reviewed changes
scripts/packages/chocolatey/.gitignore
@@ -2,5 +2,5 @@
*.zip
bazel.nuspec
tools/*.exe
tools/LICENSE
tools/params.json
tools/LICENSE*
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are unrelated drive-by fixes.

petemounce
petemounce commented Mar 14, 2017
View reviewed changes
scripts/packages/chocolatey/build.ps1
rm -force -ErrorAction SilentlyContinue ./tools/*.orig
rm -force -ErrorAction SilentlyContinue "./*.nupkg"
rm -force -ErrorAction SilentlyContinue "./bazel.nuspec"
rm -force -ErrorAction SilentlyContinue "./tools/LICENSE*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are unrelated drive-by fixes.

petemounce
petemounce commented Mar 14, 2017
View reviewed changes
scripts/packages/chocolatey/tools/chocolateyinstall.ps1
@@ -3,16 +3,18 @@ $packageName = 'bazel'

$toolsDir = Split-Path -parent $MyInvocation.MyCommand.Definition
$paramsText = get-content "$($toolsDir)\params.txt"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get-content already returns an array of strings, but it sounds like #2671 problem is that powershell v2 treats them as system.object rather than system.string. Which is super nice.

@petemounce
Copy link
Contributor Author

I've also pushed https://chocolatey.org/packages/bazel/0.4.5-rc7-20170314 so that RC has the same fix.

@meteorcloudy meteorcloudy mentioned this pull request Mar 14, 2017
Closed
@meteorcloudy
Copy link
Member

LGTM. thanks!

@meteorcloudy
Copy link
Member

I'll import this

@petemounce
Copy link
Contributor Author

Wonderful, thanks.

@bazel-io bazel-io closed this in 9bfcb6e Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@petemounce @bazel-io @googlebot @meteorcloudy