Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore overrides with --ignore_dev_dependency #23520

Closed
wants to merge 3 commits into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 5, 2024

This makes it easier to realistically test how the root module would behave as a non-root module.

RELNOTES: Overrides in the root MODULE.bazel file are now ignored with --ignore_dev_dependency. (Overrides in non-root modules are already ignored.)

This makes it easier to realistically test how the root module would behave as a non-root module.
@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Documentation Documentation improvements that cannot be directly linked to other team labels awaiting-review PR is awaiting review from an assigned reviewer labels Sep 5, 2024
@fmeum fmeum force-pushed the 19301-override-dev-dependency branch from c8c1b43 to 34ca653 Compare September 5, 2024 09:11
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a brief RELNOTE?

@fmeum fmeum requested a review from Wyverald September 5, 2024 20:54
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 5, 2024

@bazel-io fork 7.4.0

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 5, 2024
@copybara-service copybara-service bot closed this in bb7a54c Sep 9, 2024
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 9, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Sep 9, 2024
This makes it easier to realistically test how the root module would behave as a non-root module.

RELNOTES: Overrides in the root MODULE.bazel file are now ignored with `--ignore_dev_dependency`. (Overrides in non-root modules are already ignored.)

Closes bazelbuild#23520.

PiperOrigin-RevId: 672480499
Change-Id: Ifd3a99f4ed462061101fecf918d61989c9f60401
@fmeum fmeum deleted the 19301-override-dev-dependency branch September 9, 2024 12:41
github-merge-queue bot pushed a commit that referenced this pull request Sep 10, 2024
This makes it easier to realistically test how the root module would
behave as a non-root module.

RELNOTES: Overrides in the root MODULE.bazel file are now ignored with
`--ignore_dev_dependency`. (Overrides in non-root modules are already
ignored.)

Closes #23520.

PiperOrigin-RevId: 672480499
Change-Id: Ifd3a99f4ed462061101fecf918d61989c9f60401

Commit
bb7a54c

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 7.4.0 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.4.0rc1. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Documentation Documentation improvements that cannot be directly linked to other team labels team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants