unix_cc_toolchain_config: macOS supports dynamic linker #23438
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS CC toolchains based on
unix_cc_toolchain_config
(such as the one provided byrules_nixpkgs
) can no longer build dynamically linkedcc_library
targets on Bazel 7 and newer.I traced the problem back to this check in the implementation of
cc_library
:For the auto-detected toolchain on macOS, the
supports_dynamic_linker
feature is set, and both a static and dynamic library can be built.When using
unix_cc_toolchain_config
, we currently only get a static library.As an aside, I noticed that the macOS feature list is a lot shorter. I think at least some of the other features could be added here: