[7.2.1] Ensure that downloads are cancelled on repo rule restart #22758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a repository rule is restarted due to memory pressure, all its downloads must be interrupted. While this happened for `repository_ctx.download`, the `download_and_extract` method did not register its `PendingTask`. Since downloads happen on a separate executor, they would continue even through restarts, leading to warnings (see below) or even left over download temp directories. ``` WARNING: Download from https://github.com/uutils/coreutils/releases/download/0.0.26/coreutils-0.0.26-aarch64-apple-darwin.tar.gz failed: class java.io.FileNotFoundException /private/var/tmp/_bazel_fmeum/0465a0857e26a35c072f48ab751a1794/external/aspect_bazel_lib~~toolchains~coreutils_darwin_arm64/temp2576567839043404337/coreutils-0.0.26-aarch64-apple-darwin.tar.gz (No such file or directory) ``` Closes bazelbuild#22748. PiperOrigin-RevId: 643389876 Change-Id: Ia2cab4b4d73340379c17d4a1e5c327ff43505050
|
It seems the problem wasn't fixed by this change: #22748 (comment) We should probably push this back to 7.3 and not block 7.2.1? @fmeum |
|
It's one half of a fix: We also have to wait for the cancelled futures to complete, which |
|
I see, and #22680 is actually a regression in 7.2.0, then we'll wait for the fix, thanks for looking into it! |
meteorcloudy
approved these changes
Jun 17, 2024
Merged
via the queue into
bazelbuild:release-7.2.1
with commit Jun 17, 2024
d8cd073
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a repository rule is restarted due to memory pressure, all its downloads must be interrupted. While this happened for
repository_ctx.download, thedownload_and_extractmethod did not register itsPendingTask. Since downloads happen on a separate executor, they would continue even through restarts, leading to warnings (see below) or even left over download temp directories.Closes #22748.
PiperOrigin-RevId: 643389876
Change-Id: Ia2cab4b4d73340379c17d4a1e5c327ff43505050
Commit 2fb187f