Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix git branch detection in release scripts #22405

Closed
wants to merge 2 commits into from
Closed

Fix git branch detection in release scripts #22405

wants to merge 2 commits into from

Conversation

fweikert
Copy link
Member

Previously the code failed when the repository was in detached HEAD state (e.g. on CI).

@fweikert
Fix git branch detection in release scripts
4c32232 
Previously the code failed when the repository was in detached HEAD state (e.g. on CI).
@fweikert fweikert requested review from meisterT and Wyverald May 16, 2024 14:28
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 16, 2024
@fweikert fweikert added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally P1 I'll work on this now. (Assignee required) and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 16, 2024
@fweikert
Copy link
Member Author

cc @keertk - this should fix the release docs (once cherrypicked)

@keertk
Copy link
Member

keertk commented May 16, 2024

@bazel-io fork 7.2.0

@bazel-io bazel-io mentioned this pull request May 16, 2024
Closed
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 16, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request May 16, 2024
@fweikert @bazel-io
Fix git branch detection in release scripts
963764f 
Previously the code failed when the repository was in detached HEAD state (e.g. on CI).

Closes bazelbuild#22405.

PiperOrigin-RevId: 634564660
Change-Id: I60d87f1f24a1dceec6b74709a571c9630cf6bcc5
@bazel-io bazel-io mentioned this pull request May 16, 2024
Merged
@keertk keertk added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label May 16, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 17, 2024
@bazel-io @fweikert
[7.2.0] Fix git branch detection in release scripts (#22422)
ca9c753 
Previously the code failed when the repository was in detached HEAD
state (e.g. on CI).

Closes #22405.

PiperOrigin-RevId: 634564660
Change-Id: I60d87f1f24a1dceec6b74709a571c9630cf6bcc5

Commit
2028c47

Co-authored-by: Florian Weikert <fwe@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald

Assignees
No one assigned
Labels
P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fweikert @keertk @meisterT