feat(cc toolchain): support external_include_paths on macos #21949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The external_include_paths feature on mac enables specifying include paths locally with -I and with -isystem when the project is included as an external repo. This makes it possible to set -Werror against your own headers for development without propagating this to consumers of your libraries. For some reason this was only previously enabled on linux.
|
Cc @keith |
|
interesting. this doesn't exist in the apple_support toolchain today either. what ends up propagating things as external headers? |
It works with So you use that^ to specify include paths and locally they get compiled with Using the |
keith
approved these changes
May 6, 2024
|
also added this here: bazelbuild/apple_support#327 |
comius
approved these changes
May 15, 2024
|
@bazel-io flag |
|
@bazel-io fork 7.2.0 |
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
May 16, 2024
The external_include_paths feature enables specifying include paths locally with -I and with -isystem when the project is included as an external repo. This makes it possible to set -Werror against your own headers for development without propagating this to consumers of your libraries. For some reason this was only previously enabled on linux. I do not see a reason for not also enabling it on macos. Closes bazelbuild#21949. PiperOrigin-RevId: 634394452 Change-Id: I0df91b2a2c9b4a5bd52b22e64f99ea0745cb9759
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 17, 2024
…22413) The external_include_paths feature enables specifying include paths locally with -I and with -isystem when the project is included as an external repo. This makes it possible to set -Werror against your own headers for development without propagating this to consumers of your libraries. For some reason this was only previously enabled on linux. I do not see a reason for not also enabling it on macos. Closes #21949. PiperOrigin-RevId: 634394452 Change-Id: I0df91b2a2c9b4a5bd52b22e64f99ea0745cb9759 Commit d831214 Co-authored-by: Isaac Torres <isaac@isaactorz.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external_include_paths feature enables specifying include paths locally with -I and with -isystem when the project is included as an external repo.
This makes it possible to set -Werror against your own headers for development without propagating this to consumers of your libraries.
For some reason this was only previously enabled on linux. I do not see a reason for not also enabling it on macos.