-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify confusing test code and options parsing #20111
Conversation
|
Where else? |
and other occurrences in that file. |
Ah, I didn't notice that dependency at first. Thanks. |
Updated as requested, CI passes. |
Hi @gregestren, While merging the above PR our CI is gettin failed because of above code conflicts. https://buildkite.com/bazel/google-bazel-presubmit/builds/73609#018bb7f5-0d9d-4e61-899d-c7843bccc766
|
PiperOrigin-RevId: 580517309 Change-Id: I2ea3cc5b67a8a5d047972b2c85ae3a93680be612
PiperOrigin-RevId: 580517309 Change-Id: I2ea3cc5b67a8a5d047972b2c85ae3a93680be612
Updated. Let's see how CI responds. |
We can lightly refactor test code to no longer need a logical exception in Bazel's option parsing.
Supports #20107 and #20081.