Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove visionOS support from cc_test #19488

Closed

Conversation

keith
Copy link
Member

@keith keith commented Sep 11, 2023

Having this here requires folks to update platforms which can be annoying until you're using bzlmod since it's a dependency of everything. This also isn't very important since in general when testing visionOS code you should be using a rule from rules_apple.

Having this here requires folks to update platforms which can be
annoying until you're using bzlmod since it's a dependency of
everything. This also isn't very important since in general when testing
visionOS code you should be using a rule from rules_apple.
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 11, 2023
@sgowroji sgowroji added the team-Rules-CPP Issues for C++ rules label Sep 12, 2023
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 12, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 12, 2023
@keith keith deleted the ks/remove-visionos-support-from-cc_test branch September 12, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants