Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.4.0] Cherry-pick commits to fix a Windows issue #19232

Merged
merged 4 commits into from
Aug 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .bazelci/build_bazel_binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ platforms:
- "--host_copt=-w"
- "-c"
- "opt"
- "--cpu=x64_arm64_windows"
- "--incompatible_enable_cc_toolchain_resolution"
- "--config=windows_arm64"
build_targets:
- "//src:bazel.exe"
- "//src:bazel_nojdk.exe"
6 changes: 6 additions & 0 deletions .bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,19 @@ build:remote --config=ubuntu1804_java11

build:macos --macos_minimum_os=10.11

build:windows_arm64 --platforms=//:windows_arm64
build:windows_arm64 --extra_toolchains=@local_config_cc//:cc-toolchain-arm64_windows

# Enable Bzlmod
build:bzlmod --experimental_enable_bzlmod

# Enable Java 11 language features (https://github.com/bazelbuild/bazel/issues/14592)
build --java_language_version=11
build --tool_java_language_version=11

# Manually enable cc toolchain resolution before it is flipped. https://github.com/bazelbuild/bazel/issues/7260
build --incompatible_enable_cc_toolchain_resolution

# User-specific .bazelrc
try-import %workspace%/user.bazelrc

Expand Down
8 changes: 8 additions & 0 deletions BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,14 @@ platform(
parents = ["@local_config_platform//:host"],
)

platform(
name = "windows_arm64",
constraint_values = [
"@platforms//os:windows",
"@platforms//cpu:arm64",
],
)

REMOTE_PLATFORMS = ("rbe_ubuntu1804_java11",)

[
Expand Down
3 changes: 3 additions & 0 deletions third_party/blake3/blake3.BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,9 @@ cc_library(
"-DBLAKE3_NO_AVX512",
],
"@bazel_tools//src/conditions:windows_x64": [],
"@bazel_tools//src/conditions:windows_arm64": [
"-DBLAKE3_USE_NEON=0",
],
"@bazel_tools//src/conditions:darwin_arm64": [
"-DBLAKE3_USE_NEON=1",
],
Expand Down