Silence noise from download() when allow_fail=True #18484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a custom repository rule that uses download(..., allow_fail=True) to first check if an artifact is already in the repository cache. Obviously, this test is expected to fail when it is not, but Bazel is incredibly loud by printing a WARNING message for each attempt of the form: WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory) Given that allow_fail=True is meant to let the caller check for failures, warnings should be suppressed. This change makes this happen.
Wyverald
reviewed
Jun 2, 2023
...ava/com/google/devtools/build/lib/bazel/repository/starlark/StarlarkBaseExternalContext.java
Show resolved
Hide resolved
sfc-gh-mgalindo
added a commit
to Snowflake-Labs/bazel
that referenced
this pull request
Jun 10, 2024
We have a custom repository rule that uses download(..., allow_fail=True) to
first check if an artifact is already in the repository cache. Obviously,
this test is expected to fail when it is not, but Bazel is incredibly loud
by printing a WARNING message for each attempt of the form:
WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory)
Given that allow_fail=True is meant to let the caller check for failures,
warnings should be suppressed. This change makes this happen.
Upstream PR: bazelbuild#18484
Author: Julio Merino <julio.merino+oss@snowflake.com>
Date: Tue May 23 15:02:20 2023 -0700
sfc-gh-mgalindo
added a commit
to Snowflake-Labs/bazel
that referenced
this pull request
Jun 20, 2024
We have a custom repository rule that uses download(..., allow_fail=True) to
first check if an artifact is already in the repository cache. Obviously,
this test is expected to fail when it is not, but Bazel is incredibly loud
by printing a WARNING message for each attempt of the form:
WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory)
Given that allow_fail=True is meant to let the caller check for failures,
warnings should be suppressed. This change makes this happen.
Upstream PR: bazelbuild#18484
Author: Julio Merino <julio.merino+oss@snowflake.com>
Date: Tue May 23 15:02:20 2023 -0700
sfc-gh-mgalindo
added a commit
to Snowflake-Labs/bazel
that referenced
this pull request
Jun 21, 2024
We have a custom repository rule that uses download(..., allow_fail=True) to
first check if an artifact is already in the repository cache. Obviously,
this test is expected to fail when it is not, but Bazel is incredibly loud
by printing a WARNING message for each attempt of the form:
WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory)
Given that allow_fail=True is meant to let the caller check for failures,
warnings should be suppressed. This change makes this happen.
Upstream PR: bazelbuild#18484
Author: Julio Merino <julio.merino+oss@snowflake.com>
Date: Tue May 23 15:02:20 2023 -0700
sfc-gh-mgalindo
added a commit
to Snowflake-Labs/bazel
that referenced
this pull request
Jun 26, 2024
We have a custom repository rule that uses download(..., allow_fail=True) to
first check if an artifact is already in the repository cache. Obviously,
this test is expected to fail when it is not, but Bazel is incredibly loud
by printing a WARNING message for each attempt of the form:
WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory)
Given that allow_fail=True is meant to let the caller check for failures,
warnings should be suppressed. This change makes this happen.
Upstream PR: bazelbuild#18484
Author: Julio Merino <julio.merino+oss@snowflake.com>
Date: Tue May 23 15:02:20 2023 -0700
sfc-gh-mgalindo
added a commit
to Snowflake-Labs/bazel
that referenced
this pull request
Jun 28, 2024
We have a custom repository rule that uses download(..., allow_fail=True) to
first check if an artifact is already in the repository cache. Obviously,
this test is expected to fail when it is not, but Bazel is incredibly loud
by printing a WARNING message for each attempt of the form:
WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory)
Given that allow_fail=True is meant to let the caller check for failures,
warnings should be suppressed. This change makes this happen.
Upstream PR: bazelbuild#18484
Author: Julio Merino <julio.merino+oss@snowflake.com>
Date: Tue May 23 15:02:20 2023 -0700
|
Thank you for contributing to the Bazel repository! This pull request has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this PR is still relevant and should stay open, please post any comment here and the PR will no longer be marked as stale. |
sfc-gh-mgalindo
added a commit
to Snowflake-Labs/bazel
that referenced
this pull request
Jan 21, 2025
We have a custom repository rule that uses download(..., allow_fail=True) to
first check if an artifact is already in the repository cache. Obviously,
this test is expected to fail when it is not, but Bazel is incredibly loud
by printing a WARNING message for each attempt of the form:
WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory)
Given that allow_fail=True is meant to let the caller check for failures,
warnings should be suppressed. This change makes this happen.
Upstream PR: bazelbuild#18484
Author: Julio Merino <julio.merino+oss@snowflake.com>
Date: Tue May 23 15:02:20 2023 -0700
sfc-gh-mgalindo
added a commit
to Snowflake-Labs/bazel
that referenced
this pull request
Feb 8, 2025
We have a custom repository rule that uses download(..., allow_fail=True) to
first check if an artifact is already in the repository cache. Obviously,
this test is expected to fail when it is not, but Bazel is incredibly loud
by printing a WARNING message for each attempt of the form:
WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory)
Given that allow_fail=True is meant to let the caller check for failures,
warnings should be suppressed. This change makes this happen.
Upstream PR: bazelbuild#18484
Author: Julio Merino <julio.merino+oss@snowflake.com>
Date: Tue May 23 15:02:20 2023 -0700
jmmv
added a commit
to Snowflake-Labs/bazel
that referenced
this pull request
Feb 13, 2025
We have a custom repository rule that uses download(..., allow_fail=True) to first check if an artifact is already in the repository cache. Obviously, this test is expected to fail when it is not, but Bazel is incredibly loud by printing a WARNING message for each attempt of the form: WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory) Given that allow_fail=True is meant to let the caller check for failures, warnings should be suppressed. This change makes this happen. Upstream PR: bazelbuild#18484
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a custom repository rule that uses download(..., allow_fail=True) to first check if an artifact is already in the repository cache. Obviously, this test is expected to fail when it is not, but Bazel is incredibly loud by printing a WARNING message for each attempt of the form:
WARNING: Download from file:/mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 failed: class java.io.FileNotFoundException /mnt/jenkins/home/jenkins/.cache/bazel/_bazel_jenkins/5d6e21225a0f8eb93bf6c0ff841144e1/external/anaconda-python_3.10_x86_64/python-3.10.9-h7a1cb2a_2.tar.bz2 (No such file or directory)
Given that allow_fail=True is meant to let the caller check for failures, warnings should be suppressed. This change makes this happen.