[6.2.0]Enable revised output directory hash suffix computation #18088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flips `--experimental_output_directory_naming_scheme` and `--experimental_exec_configuration_distinguisher` to `diff_against_baseline` and `off`, respectively, which makes it so that Starlark transitions can return to previous configurations, thus improving cache hit rates. Also changes the fixed platform suffix in the exec configuration from an empty string to `"exec"` for compatibility with logic that looks for the substring `-exec-` in paths to determine whether the current configuration is the exec configuration. As a result of this commit, output directory paths can change in the following ways: * `-ST-<hash>` suffixes can change or disappear and, in rare cases, appear where they previously didn't * for exec configuration directories, `k8-opt-exec-2B5CBBC6` becomes `k8-opt-exec-ST-011b9bdc32ed` This may result in tool paths that are seven characters longer, which can cause builds on Windows to fail that were already very close to the `MAX_PATH` limit. A follow-up commit will reduce the length of the hash by three characters, bringing that increase down to four. Work towards bazelbuild#14023 Closes bazelbuild#16910. PiperOrigin-RevId: 523999034 Change-Id: Id5548a00b62ebfe7889cd40177995210ecc224c1
|
@kshyanashree We ultimately decided against cherry-picking this. Sorry for the effort! |
Ohh I see! No problem, I am closing this PR.Thanks for the info! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flips
--experimental_output_directory_naming_schemeand--experimental_exec_configuration_distinguishertodiff_against_baselineandoff, respectively, which makes it so that Starlark transitions can return to previous configurations, thus improving cache hit rates.Also changes the fixed platform suffix in the exec configuration from an empty string to
"exec"for compatibility with logic that looks for the substring-exec-in paths to determine whether the current configuration is the exec configuration.As a result of this commit, output directory paths can change in the following ways:
-ST-<hash>suffixes can change or disappear and, in rare cases, appear where they previously didn'tk8-opt-exec-2B5CBBC6becomesk8-opt-exec-ST-011b9bdc32edThis may result in tool paths that are seven characters longer, which can cause builds on Windows to fail that were already very close to the
MAX_PATHlimit. A follow-up commit will reduce the length of the hash by three characters, bringing that increase down to four.Work towards #14023
Closes #16910.
Commit: 94d8bd3
PiperOrigin-RevId: 523999034
Change-Id: Id5548a00b62ebfe7889cd40177995210ecc224c1