Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create separate java_tools for darwin_x86_64 and darwin_arm64 #17782

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,8 @@ sh_binary(
"tmp/build",
"--platform",
] + select({
"//src/conditions:darwin": ["darwin"],
hvadehra marked this conversation as resolved.
Show resolved Hide resolved
"//src/conditions:darwin_x86_64": ["darwin_x86_64"],
"//src/conditions:darwin_arm64": ["darwin_arm64"],
"//src/conditions:windows": ["windows"],
"//src/conditions:linux": ["linux"],
"//conditions:default": ["unknown"],
Expand Down
2 changes: 1 addition & 1 deletion src/create_java_tools_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ trap "rm -fr $tmp_dir" EXIT

gcs_bucket="gs://bazel-mirror/bazel_java_tools"

for platform in "linux" "windows" "darwin"; do
for platform in "linux" "windows" "darwin_x86_64" "darwin_arm64"; do
rc_url="release_candidates/java/v${java_tools_version}/java_tools_${platform}-v${java_tools_version}-rc${rc}.zip"

if [[ $release == "true" ]]; then
Expand Down