Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate shorter transition output directory suffixes #17474

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Feb 12, 2023

Reduces the length of the hash fragment by three characters, which helps with Windows path length limitations. By switching from base16 to base32 encoding, this decreases the entropy by only 3 bits (down to 45 bits).

Work towards #14023

@fmeum fmeum force-pushed the 14023-shorter-st-hash branch from 40dc816 to 6641f96 Compare February 12, 2023 10:53
Reduces the length of the hash fragment by three characters while
switching to a more efficient encoding scheme, which helps with Windows
path length limitations.
@fmeum fmeum force-pushed the 14023-shorter-st-hash branch from 6641f96 to 18c2d6b Compare February 12, 2023 11:19
@fmeum fmeum marked this pull request as ready for review February 12, 2023 11:36
@fmeum fmeum requested a review from oquenchil as a code owner February 12, 2023 11:37
@fmeum
Copy link
Collaborator Author

fmeum commented Feb 12, 2023

@sdtwigg Could you review this PR?

@sgowroji sgowroji added team-Configurability platforms, toolchains, cquery, select(), config transitions awaiting-review PR is awaiting review from an assigned reviewer labels Feb 12, 2023
@keertk keertk requested a review from sdtwigg February 21, 2023 14:34
@katre katre removed the request for review from sdtwigg March 31, 2023 15:13
@katre katre requested review from sdtwigg and removed request for oquenchil March 31, 2023 15:14
@fmeum
Copy link
Collaborator Author

fmeum commented Apr 25, 2023

@sdtwigg Friendly ping, could you take a look?

@fmeum fmeum closed this Sep 21, 2023
@fmeum fmeum deleted the 14023-shorter-st-hash branch September 21, 2023 10:36
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants