Add --skip_incompatible_explicit_targets option
#17404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heads up: I ported this patch from bazel 4.2 so I'm still working on fixing the compile errors. |
6915638 to
d62de1f
Compare
|
Okay, as far as I can tell these test failures aren't related to my changes so this is ready for review. Any feedback is welcome! |
|
Continued the conversation on the issue. |
gregestren
reviewed
Feb 23, 2023
src/main/java/com/google/devtools/build/lib/buildtool/BuildRequestOptions.java
Outdated
Show resolved
Hide resolved
|
Hi @marczych-zoox, Could you please resolve the code conflicts and review comments. Thanks! |
This adds an argument to skip incompatible targets even if they were explicitly requested on the command line. This is useful for CI to allow it to build changed targets from rdeps queries without needing to filter them all through a cquery to check if they are compatible. Closes bazelbuild#17403 RELNOTES: Add `--skip_incompatible_explicit_targets` option
d62de1f to
a1ea798
Compare
|
I pushed a fix for the inline comment as well as the one from the ticket to move it to Let me know if there is anything else that needs to be done! |
gregestren
approved these changes
Mar 20, 2023
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
This adds an argument to skip incompatible targets even if they were explicitly requested on the command line. This is useful for CI to allow it to build changed targets from rdeps queries without needing to filter them all through a cquery to check if they are compatible. Closes bazelbuild#17403 RELNOTES: Add `--skip_incompatible_explicit_targets` option Closes bazelbuild#17404. PiperOrigin-RevId: 519636134 Change-Id: I16d6a4896cf920f42364cba162001b1bb7658e65
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an argument to skip incompatible targets even if they were explicitly requested on the command line. This is useful for CI to allow it to build changed targets from rdeps queries without needing to filter them all through a cquery to check if they are compatible.
Closes #17403
RELNOTES: Add
--skip_incompatible_explicit_targetsoption