Add autoValueGson #17300
Closed
Add autoValueGson #17300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wyverald
reviewed
Jan 27, 2023
Wyverald
approved these changes
Jan 27, 2023
Wyverald
reviewed
Jan 27, 2023
|
Hi @Wyverald , I could see above PR has third-party changes. Should i merge the third-party changes first and do the remaining through CL or vice versa ? |
|
For this one, you'll probably need to merge the non-third-party changes first and then do the third-party ones. Thank you! |
|
Hi @SalmaSamy, Could you please squash all the commits into one, to merge the third-party changes. Thanks! |
…azel into Add-auto-value-gson
…al header mappings. Since there is no way to convert Depset of Tuples to Depset of Pairs without flattening it, refactor the code so that Pairs are replaced by Tuples. PiperOrigin-RevId: 505979345 Change-Id: I947d8f19823c65ebbaf18466734aba774222e79d
Previously, different `LibraryToLinkValue` inherited classes are created so that some heap overhead can be reduced. However, it is still possible equal objects with the same `name` are constructed multiple times, leading to multiple copies of the same object in heap. The most straightforward idea to reduce the overhead is to utilize `Interner`. So, this commit applies `WeakInterner` to all of these static creation methods. PiperOrigin-RevId: 505987062 Change-Id: I9e99adb3b2a6788467f6a290fb4fcaecf8ff0b65
|
See #17379 instead |
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
AutoValueGson allows deserializing objects created from Auto_value classes Closes #17300. PiperOrigin-RevId: 505706165 Change-Id: Icb4bbb3f6f696da4f437d6e40094613428c27193
SalmaSamy
added a commit
that referenced
this pull request
Apr 19, 2023
AutoValueGson allows deserializing objects created from Auto_value classes Closes #17300. PiperOrigin-RevId: 505706165 Change-Id: Icb4bbb3f6f696da4f437d6e40094613428c27193 # Conflicts: # MODULE.bazel # WORKSPACE # maven_install.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AutoValueGson allows deserializing objects created from Auto_value classes