Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display human readable bytes in download progress #16062

Closed
wants to merge 1 commit into from
Closed

Display human readable bytes in download progress #16062

wants to merge 1 commit into from

Conversation

blindpirate
Copy link
Contributor

Before:

Fetching https://mirror.bazel.build/..._x64.tar.gz; 28,324,614B 9s

After:

Fetching https://mirror.bazel.build/..._x64.tar.gz; 27 MB (28,324,614B) 9s

@sgowroji sgowroji added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website awaiting-review PR is awaiting review from an assigned reviewer labels Aug 8, 2022
Wyverald
Wyverald approved these changes Sep 27, 2022
View reviewed changes
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Oct 4, 2022
@meteorcloudy
Copy link
Member

We can use https://cs.opensource.google/bazel/bazel/+/master:src/main/java/com/google/devtools/build/lib/remote/util/Utils.java;l=588?q=bytesCountToDisplayString&sq=&ss=bazel to avoid adding the apache_commons_io dependency.

@meteorcloudy meteorcloudy added awaiting-user-response Awaiting a response from the author and removed awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally labels Oct 4, 2022
@blindpirate blindpirate force-pushed the human-readable-bytes-in-progress branch from 8589747 to e469fd5 Compare October 4, 2022 23:13
@blindpirate
Display human readable bytes in download progress
db5787c 
Before:

```
Fetching https://mirror.bazel.build/..._x64.tar.gz; 28,324,614B 9s
```

After:

```
Fetching https://mirror.bazel.build/..._x64.tar.gz; 27 MB (28,324,614B) 9s
```
@blindpirate blindpirate force-pushed the human-readable-bytes-in-progress branch from e469fd5 to db5787c Compare October 4, 2022 23:13
@blindpirate
Copy link
Contributor Author

@meteorcloudy Good to know! PTAL.

@blindpirate
Copy link
Contributor Author

The CI failure doesn't look like my fault.

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-user-response Awaiting a response from the author labels Oct 5, 2022
@copybara-service copybara-service bot closed this in 801e01c Oct 6, 2022
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Oct 6, 2022
aiuto pushed a commit to aiuto/bazel that referenced this pull request Oct 12, 2022
@blindpirate @aiuto
Display human readable bytes in download progress
491ef46 
Before:

```
Fetching https://mirror.bazel.build/..._x64.tar.gz; 28,324,614B 9s
```

After:

```
Fetching https://mirror.bazel.build/..._x64.tar.gz; 27 MB (28,324,614B) 9s
```

Closes bazelbuild#16062.

PiperOrigin-RevId: 479250818
Change-Id: Iea3ea6082a0dfb46456e25ea219a0f287e90e1fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@Wyverald Wyverald Wyverald approved these changes

Assignees
No one assigned
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blindpirate @meteorcloudy @Wyverald @sgowroji