Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade zlib to 1.2.12 #15497

Closed
wants to merge 1 commit into from
Closed

Upgrade zlib to 1.2.12 #15497

wants to merge 1 commit into from

Conversation

meteorcloudy
Copy link
Member

Fixes #15386

@meteorcloudy meteorcloudy requested a review from Wyverald May 13, 2022 14:42
@meteorcloudy
Copy link
Member Author

I was planning to replace zlib with an external repo in WORKSPACE, but turns out @bazel_tools embeds zlib sources currently, so it's harder to set it up. We can revisit after clean up @bazel_tools (should be easier when it's a Bazel module).

@sgowroji sgowroji added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer labels May 13, 2022
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 17, 2022
@meteorcloudy
Copy link
Member Author

@sgowroji Please help merge this one, thanks!

bazel-io pushed a commit that referenced this pull request May 17, 2022
@meteorcloudy @sgowroji
Upgrade zlib to 1.2.12
668805a 
Partial commit for third_party/*, see #15497.

Signed-off-by: Sunil Gowroji <sgowroji@google.com>
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 17, 2022
@meteorcloudy
Copy link
Member Author

Merged at 668805a

@ckolli5 ckolli5 mentioned this pull request May 19, 2022
Merged
copybara-service bot pushed a commit that referenced this pull request May 25, 2022
@meteorcloudy @copybara-github
Bump the limit of Bazel install base size
55ab360 
This is due to the upgrade of zlib: #15497
Downstream failure: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2482#0180f962-1169-4a22-bffd-f455198c9b38

PiperOrigin-RevId: 450948972
Change-Id: Ic67523cc75c7445b9f3478d5c8343956280b8cb6
meteorcloudy added a commit to meteorcloudy/bazel that referenced this pull request May 27, 2022
@meteorcloudy
Bump the limit of Bazel install base size
ae56a9a 
This is due to the upgrade of zlib: bazelbuild#15497
Downstream failure: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2482#0180f962-1169-4a22-bffd-f455198c9b38

PiperOrigin-RevId: 450948972
Change-Id: Ic67523cc75c7445b9f3478d5c8343956280b8cb6
@meteorcloudy meteorcloudy mentioned this pull request May 27, 2022
Merged
meteorcloudy added a commit that referenced this pull request May 27, 2022
@meteorcloudy
Bump the limit of Bazel install base size (#15585)
0120118 
This is due to the upgrade of zlib: #15497
Downstream failure: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2482#0180f962-1169-4a22-bffd-f455198c9b38

PiperOrigin-RevId: 450948972
Change-Id: Ic67523cc75c7445b9f3478d5c8343956280b8cb6
ckolli5 added a commit that referenced this pull request May 27, 2022
@ckolli5 @meteorcloudy
Upgrade zlib to 1.2.12 (#15534)
0758347 
Partial commit for third_party/*, see #15497.

Signed-off-by: Sunil Gowroji <sgowroji@google.com>

Co-authored-by: Yun Peng <pcloudy@google.com>
@meteorcloudy meteorcloudy mentioned this pull request May 31, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upgrade zlib to version 1.2.12
3 participants
@meteorcloudy @Wyverald @sgowroji