Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store start/end timestamps of locally executed actions in the disk ca… #15439

Merged
merged 1 commit into from
May 9, 2022
Merged

Store start/end timestamps of locally executed actions in the disk ca… #15439

merged 1 commit into from
May 9, 2022

Conversation

ckolli5
Copy link

@ckolli5 ckolli5 commented May 9, 2022

…che.

This is necessary to ensure that the generate-xml.sh action associated with
every test, which embeds the test runner wall time, doesn't execute again when
run on a warm disk cache.

This PR makes the following changes:

  1. Add SpawnResult#getStartTime alongside existing #getWallTime and populate
    it in various SpawnRunner implementations.
  2. Populate the ExecutedActionMetadata with the start/wall times for a
    locally executed spawn when storing it in the disk cache.
  3. Populate the SpawnResult with the start/wall times for a spawn
    retrieved from the disk cache.
  4. Add a regression test for the scenario described above.

In order to avoid changes to the remote execution protocol, the start/end
time are stored in the existing ActionResult.execution_metadata fields.
Since there is some mismatch between this field and the metrics available
in a SpawnResult, this might be revisited later.

Fixes #14426.

Closes #15256.

PiperOrigin-RevId: 443052342

…che.

This is necessary to ensure that the generate-xml.sh action associated with
every test, which embeds the test runner wall time, doesn't execute again when
run on a warm disk cache.

This PR makes the following changes:

1. Add SpawnResult#getStartTime alongside existing #getWallTime and populate
   it in various SpawnRunner implementations.
2. Populate the ExecutedActionMetadata with the start/wall times for a
   locally executed spawn when storing it in the disk cache.
3. Populate the SpawnResult with the start/wall times for a spawn
   retrieved from the disk cache.
4. Add a regression test for the scenario described above.

In order to avoid changes to the remote execution protocol, the start/end
time are stored in the existing ActionResult.execution_metadata fields.
Since there is some mismatch between this field and the metrics available
in a SpawnResult, this might be revisited later.

Fixes #14426.

Closes #15256.

PiperOrigin-RevId: 443052342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants