Use tree artifacts in bootclasspath rule #15384
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
853e084 to
c87938e
Compare
|
@cushon This is a follow-up to #6393, which is close to being fixed. It is currently stacked on #15366 and marked as draft as long as that PR hasn't been merged, but if you have capacity, you could already review it. The reason I'm interested in making this change is ongoing work on a structured path remapping approach to #6526 (comment) which requires forgoing |
Remote execution now creates the directories for output tree artifacts prior to execution, so that the output of the Java compiler can be modelled as a tree artifact even though not all versions create the output directory if it doesn't exist.
c87938e to
765ec3e
Compare
|
@cushon The PRs this was based on have been merged, ready for review now. |
cushon
approved these changes
May 9, 2022
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
May 19, 2022
Remote execution now creates the directories for output tree artifacts prior to execution, so that the output of the Java compiler can be modelled as a tree artifact even though not all versions create the output directory if it doesn't exist. Closes bazelbuild#15384. PiperOrigin-RevId: 447759377
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
May 19, 2022
Remote execution now creates the directories for output tree artifacts prior to execution, so that the output of the Java compiler can be modelled as a tree artifact even though not all versions create the output directory if it doesn't exist. Closes bazelbuild#15384. PiperOrigin-RevId: 447759377
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
Jul 6, 2022
Remote execution now creates the directories for output tree artifacts prior to execution, so that the output of the Java compiler can be modelled as a tree artifact even though not all versions create the output directory if it doesn't exist. Closes bazelbuild#15384. PiperOrigin-RevId: 447759377
ckolli5
added a commit
that referenced
this pull request
Jul 7, 2022
Remote execution now creates the directories for output tree artifacts prior to execution, so that the output of the Java compiler can be modelled as a tree artifact even though not all versions create the output directory if it doesn't exist. Closes #15384. PiperOrigin-RevId: 447759377 Co-authored-by: Chenchu K <ckolli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote execution now creates the directories for output tree artifacts
prior to execution, so that the output of the Java compiler can be
modelled as a tree artifact even though not all versions create the
output directory if it doesn't exist.