Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record additional profiling information for remotely executed actions. #15348

Closed
wants to merge 1 commit into from
Closed

Record additional profiling information for remotely executed actions. #15348

wants to merge 1 commit into from

Conversation

tjgq
Copy link
Contributor

@tjgq tjgq commented Apr 26, 2022

No description provided.

@tjgq tjgq requested a review from a team as a code owner April 26, 2022 15:36
@tjgq tjgq requested a review from coeuvre April 26, 2022 15:36
@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Apr 27, 2022
meisterT
meisterT reviewed Apr 27, 2022
View reviewed changes
Copy link
Member

@meisterT meisterT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post an example screenshot of a profile with this new info?

@tjgq
Copy link
Contributor Author

tjgq commented Apr 27, 2022

Can you post an example screenshot of a profile with this new info?

It's the bits under "execute remotely".

image

meisterT
meisterT reviewed Apr 27, 2022
View reviewed changes
src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java Outdated

logProfileTask(converter, executedActionMetadata.getQueuedTimestamp(),
executedActionMetadata.getWorkerStartTimestamp(),
REMOTE_QUEUE, "Remote execution queuing time");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider using just REMOTE_QUEUE.toString() here (and similar below) instead of the full description. I think that the enum names are still easy to read for humans and much shorter, so you don't see abbreviations like Remote execu... like you do now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider removing Remote ... prefix as they are all under execute remotely span.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

coeuvre
coeuvre approved these changes Apr 27, 2022
View reviewed changes
src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java Outdated

logProfileTask(converter, executedActionMetadata.getQueuedTimestamp(),
executedActionMetadata.getWorkerStartTimestamp(),
REMOTE_QUEUE, "Remote execution queuing time");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also consider removing Remote ... prefix as they are all under execute remotely span.

@tjgq tjgq force-pushed the remote-profiling branch from 81cda76 to 0cbbd02 Compare April 28, 2022 10:18
@bazel-io bazel-io closed this in 394ddb8 May 2, 2022
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 2, 2022
@ckolli5
Copy link

ckolli5 commented May 4, 2022

@bazel-io fork 5.2.0

@bazel-io bazel-io mentioned this pull request May 4, 2022
Closed
@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label May 4, 2022
@ckolli5 ckolli5 mentioned this pull request May 10, 2022
Merged
ckolli5 added a commit that referenced this pull request May 10, 2022
@ckolli5 @tjgq
Record additional profiling information for remotely executed actions. (
aabd7fb 
#15443)

Closes #15348.

PiperOrigin-RevId: 445882024

Co-authored-by: Tiago Quelhas <tjgq@google.com>
meteorcloudy pushed a commit that referenced this pull request May 10, 2022
@ckolli5 @tjgq @meteorcloudy
Record additional profiling information for remotely executed actions. (
a430042 
#15443)

Closes #15348.

PiperOrigin-RevId: 445882024

Co-authored-by: Tiago Quelhas <tjgq@google.com>
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
@tjgq tjgq deleted the remote-profiling branch December 8, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meisterT meisterT meisterT left review comments

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tjgq @brentleyjones @ckolli5 @meisterT @coeuvre @bazel-io @sgowroji @ShreeM01