-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for .ar archives (and .deb files) #15132
Conversation
I would like to find a way do to this without adding more code in Bazel. Perhaps we can do this mostly in starlark defined workspace rules. I'm very familiar with the .deb and .ar formats on the writing side, so I'll take a look at this, but it might not be until next week. |
How do you plan to do that? I think this PR extends the functionality of |
I agree with @meteorcloudy, to implement this in pure starlark would involve decoding .ar files in Starlark code. This is not impossible, but certainly difficult given that we wouldn't really be able to use libraries. Another option is to shell out to a native executable, but that requires users to install or download such a binary. |
src/main/java/com/google/devtools/build/lib/bazel/repository/ArFunction.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/devtools/build/lib/bazel/repository/ArFunction.java
Outdated
Show resolved
Hide resolved
@bazel-io flag |
@bazel-io fork 5.2.0 |
1 similar comment
@bazel-io fork 5.2.0 |
This implements #[15130](bazelbuild#15130). As I was updating the docs for .ar and .deb formats, I also addressed some previous formats that had been added but not propagated through to all the documentation places. Closes bazelbuild#15132. PiperOrigin-RevId: 439569440
This implements #[15130](#15130). As I was updating the docs for .ar and .deb formats, I also addressed some previous formats that had been added but not propagated through to all the documentation places. Closes #15132. PiperOrigin-RevId: 439569440 Co-authored-by: Kevin Lubick <kjlubick@google.com>
Fixes #13905? |
This implements #15130.
As I was updating the docs for .ar and .deb formats, I also addressed some previous formats that had been added but not propagated through to all the documentation places.