Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for .ar archives (and .deb files) #15132

Closed
wants to merge 5 commits into from

Conversation

kjlubick
Copy link
Contributor

This implements #15130.

As I was updating the docs for .ar and .deb formats, I also addressed some previous formats that had been added but not propagated through to all the documentation places.

@aiuto aiuto self-assigned this Mar 30, 2022
@aiuto
Copy link
Contributor

aiuto commented Mar 30, 2022

I would like to find a way do to this without adding more code in Bazel. Perhaps we can do this mostly in starlark defined workspace rules. I'm very familiar with the .deb and .ar formats on the writing side, so I'll take a look at this, but it might not be until next week.

@aiuto aiuto requested review from aiuto and Wyverald March 30, 2022 14:21
@meteorcloudy
Copy link
Member

Perhaps we can do this mostly in starlark defined workspace rules.

How do you plan to do that? I think this PR extends the functionality of repository_ctx.download_and_extract, which is implemented in native code. Not sure how it could be implemented in pure starlark.

@kjlubick
Copy link
Contributor Author

kjlubick commented Apr 4, 2022

I agree with @meteorcloudy, to implement this in pure starlark would involve decoding .ar files in Starlark code. This is not impossible, but certainly difficult given that we wouldn't really be able to use libraries. Another option is to shell out to a native executable, but that requires users to install or download such a binary.

@bazel-io bazel-io closed this in 9c98120 Apr 5, 2022
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 5, 2022
@ckolli5
Copy link

ckolli5 commented Apr 11, 2022

@bazel-io fork 5.2.0

1 similar comment
@ckolli5
Copy link

ckolli5 commented Apr 11, 2022

@bazel-io fork 5.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 11, 2022
meteorcloudy pushed a commit to meteorcloudy/bazel that referenced this pull request Apr 12, 2022
This implements #[15130](bazelbuild#15130).

As I was updating the docs for .ar and .deb formats, I also addressed some previous formats that had been added but not propagated through to all the documentation places.

Closes bazelbuild#15132.

PiperOrigin-RevId: 439569440
ckolli5 pushed a commit that referenced this pull request Apr 20, 2022
This implements #[15130](#15130).

As I was updating the docs for .ar and .deb formats, I also addressed some previous formats that had been added but not propagated through to all the documentation places.

Closes #15132.

PiperOrigin-RevId: 439569440

Co-authored-by: Kevin Lubick <kjlubick@google.com>
@uhthomas
Copy link
Contributor

Fixes #13905?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants