-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Traverse parent DexClassLoaders for native libraries in DelegateClassLoader #14965
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
88e6744
to
4f29b96
Compare
Thanks for the PR, Ben! LGTM, I will push this through the internal tests. |
Oh, I didn't see your comment until now (after I've already merged this PR). I'll discuss with Alex. |
This only fixes part of the issue where mobile install can't find native libraries. The pull request that @oliviernotteghem put up also addresses the reverse problem where native libraries need to call back into the JVM. You can reproduce this using https://github.com/facebook/flipper. It's been a while since i've looked at their code but I believe this is where it will error out https://github.com/facebook/flipper/blob/main/android/src/main/cpp/sonar.cpp#L46-L48 |
Thanks for the information, Ben. I'll propose some next steps internally; will update the bug after that. |
Fixes #13661 by traversing the class loaders looking for native libraries.