Add non-Starlark optional toolchain API #14770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of Optional Toolchains (bazelbuild#14726).
2bb4e06 to
a4e3d59
Compare
gregestren
reviewed
Feb 9, 2022
| /** The toolchain type this requirement is for. */ | ||
| public abstract Label toolchainType(); | ||
|
|
||
| /** Whether the toolchain type is mandatory or optional. */ |
There was a problem hiding this comment.
Can we contextualize this comment a bit more? Just another sentence suggesting the implication of these terms?
gregestren
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Optional Toolchains (#14726).