Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for remote cache early return during compressed blob upload #14655

Closed
wants to merge 1 commit into from
Closed

Add test for remote cache early return during compressed blob upload #14655

wants to merge 1 commit into from

Conversation

bduffany
Copy link
Contributor

@bduffany bduffany commented Jan 27, 2022 •
edited
Loading

Adds a test for d184e48

@bduffany bduffany mentioned this pull request Jan 27, 2022
Closed
@gregestren gregestren added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Feb 1, 2022
@coeuvre
Copy link
Member

coeuvre commented Apr 8, 2022

Since the mentioned issue was fixed. Can you rebase so we can merge this test?

@bduffany bduffany force-pushed the compressed-upload-fail branch from fdeaa92 to ae03833 Compare April 16, 2022 17:09
@bduffany bduffany changed the title Add failing test for comitted_size mismatch Add test for remote cache early return during compressed blobs upload Apr 16, 2022
@bduffany bduffany changed the title Add test for remote cache early return during compressed blobs upload Add test for remote cache early return during compressed blob upload Apr 16, 2022
@bduffany bduffany marked this pull request as ready for review April 16, 2022 17:10
@bduffany bduffany requested a review from a team as a code owner April 16, 2022 17:10
@bduffany
Copy link
Contributor Author

bduffany commented Apr 16, 2022 •
edited
Loading

Since the mentioned issue was fixed. Can you rebase so we can merge this test?

Done, thanks for the reminder!

@bduffany bduffany force-pushed the compressed-upload-fail branch from ae03833 to 25bc6ce Compare April 16, 2022 19:23
@bduffany bduffany force-pushed the compressed-upload-fail branch from 25bc6ce to c9012fd Compare April 16, 2022 19:25
@bazel-io bazel-io closed this in 9ad3511 Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees

@coeuvre coeuvre

Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bduffany @coeuvre @gregestren